search

NativeScript / nx

NativeScript for Nx.
Other
64 stars 17 forks source link

fix: windows node spawn einval error #77

Closed rob4226 closed 2 months ago

rob4226 commented 3 months ago

All commands fail to run on Windows with newer Node versions with Error: spawn EINVAL due to https://github.com/nodejs/node/commit/69ffc6d50dbd9d7d0257f5b9b403026e1aa205ee. This commit adds shell: true to all the spawn calls when the platform is Windows.

This is similar to https://github.com/NativeScript/NativeScript/issues/10532

edusperoni commented 3 months ago

Hello!

Thanks for the contribution! But I believe this change by itself is insufficient and breaks a few projects (see https://github.com/NativeScript/nativescript-cli/pull/5808). Can you add the same logic to add quotes on windows on this PR?

Thank you!

rob4226 commented 3 months ago

Hello, can you please take a look now? Thanks.