NativeScript / nx

NativeScript for Nx.
Other
64 stars 17 forks source link

Nx 20 support #79

Closed pawel-twardziak closed 1 month ago

pawel-twardziak commented 1 month ago
NathanWalker commented 1 month ago

Thank you for kicking this off!

pawel-twardziak commented 1 month ago

hi @NathanWalker I need this migration for my green field project. Almost done, tested and all work. Still some chores to get done.

pawel-twardziak commented 1 month ago

@NathanWalker I will be working on this for the next week - so should be done soon :)

NathanWalker commented 1 month ago

ok excellent @pawel-twardziak just ping when ready and we'll merge this into the other pending PR which has ton of executor standardization improvements before releasing v20.

pawel-twardziak commented 1 month ago

Hi @NathanWalker I see there has beed done a huge job out there https://github.com/NativeScript/nx/pull/57 Do you want to merge my work DIRECTLY into that one or passing through the main branch?

Btw I have got sick a bit. Getting better and better

NathanWalker commented 1 month ago

If you want to try the merge, you could try merging his into yours or vice versa - ideally we want to merge both your work here and that one.

pawel-twardziak commented 1 month ago

I don't like merging other people's work with anything but the main :) Simply out of respect for someone else's work. I recommend merging one of the work first - mine is simpler (just one responsibility) so this could be the first imho. That https://github.com/NativeScript/nx/pull/57 PR takes many resposibilities which is not the best approach 😆 so we could continue on that one next to eventually get both of them done :)

pawel-twardziak commented 1 month ago

And I am activly migrating https://github.com/nxext/nx-extensions (it is done, now fixing period) to NX20 too, so I work on two fronts 😆

NathanWalker commented 1 month ago

Agreed, just make this ready for review when ready and we'll merge this first then.

pawel-twardziak commented 1 month ago

Thank you @NathanWalker 👍 I am sluggish as being sick but I am speeding up! 😺 I assume I should get mine done by Saturday (including).

pawel-twardziak commented 1 month ago

Hi @NathanWalker I will be continuing on it this Sunday (unfortunately tomorrow I cannot). Expect my PR ready by 4pm. I was delayed due to illness.

pawel-twardziak commented 1 month ago

@NathanWalker ready to CR. In general, for some reason, fixing package dep version while lint --fix does not work. I dunno why. Need to investigate it a bit more. For now, I did it manually.

UPDATE: I've just activated fixing package dep versions while lint --fix

pawel-twardziak commented 1 month ago

@NathanWalker are you there? :)

NathanWalker commented 1 month ago

We’ll check that out and get this merged today