fix: rm extra PaymentEvent.Result.SUCCESS call

NativeScript / payments

In-App Purchase, Subscriptions, Google Pay, Apple Pay for NativeScript

Apache License 2.0

33 stars 11 forks source link

fix: rm extra PaymentEvent.Result.SUCCESS call #34

Closed brianrclow closed 5 months ago

brianrclow commented 7 months ago

When using it across multiple android devices, we were receiving 2 success calls every time
Looking into it, there is a PaymentEvent.Result.SUCCESS in 2 places inside the finalizeOrder(), this appears to be a bug
Removing the extra success call now only calls success 1 time from finalizeOrder(), removed lines 301-305
on save it looks like spacing was updated as well (which makes this PR harder to read sorry about that)

brianrclow commented 5 months ago

@triniwiz can you take a look at this? I think it's a fairly clear change, hoping to assist in getting this released relatively soon. Happy to help with debugging or in any way.