NativeScript / plugin-seed

Build NativeScript Plugins Fast ⚡
https://docs.nativescript.org/plugins/plugin-workspace-guide
Apache License 2.0
45 stars 11 forks source link

fix: angular tsconfig wrong @demo/shared path #25

Open agonper opened 2 years ago

agonper commented 2 years ago

Error description

Angular demo build cannot find files under @demo/shared scope

Steps to reproduce

  1. Download plugin seed
  2. Setup and config
  3. Add a plugin
  4. Try to build the Angular demo app
  5. Webpack will fail with the following error: image
NathanWalker commented 2 years ago

Thanks @agonper there's one other adjustment the tools need with latest updates to ensure the angular app's tsconfig is correct, it should instead annotate along with each added package like this for example:

{
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
    "paths": {
      "~/*": ["src/*"],
      "@demo/shared": ["tools/demo/index.ts"],
      "@nativescript/*": ["packages/*"]
    }
  },
  "files": ["./references.d.ts", "./src/main.ts", "./src/polyfills.ts"],
  "include": ["../../packages/**/references.d.ts", "../../**/*.android.ts", "../../**/*.ios.ts"]
}

That would allow natural livesync changes with Angular demo. I'll add this adjustment in the tools this week.

agonper commented 2 years ago

You're welcome @NathanWalker. I'm happy to help 🙂 .

That would allow natural livesync changes with Angular demo.

I noticed that too. Now with Ivy it should no longer be necessary to pre-build Angular plugins for live sync, right? That would be an enormous DX boost!

Looking forward seeing that adjustment! Thanks for making NativeScript better every day 😄

NathanWalker commented 2 years ago

Correct! Yes that should allow the angular demo to work/livesync like the vanilla demo. Thanks for the kind words 🤗

jnorkus commented 2 years ago

Any progress on this issue? I have tried implementing the tsconfig changes but there are still errors resolving modules.