search

NativeScript / plugins

@nativescript plugins to help with your developments.
https://docs.nativescript.org/plugins/index.html
Apache License 2.0
187 stars 104 forks source link

Populate the shared instance config #545

Closed sitefinitysteve closed 7 months ago

sitefinitysteve commented 8 months ago

Not sure how this ever worked? The signin method calls the sharedInstance config, but it's always empty

Even with something this simple, the .json is read and client IDs and stuff are set fine after configure

         await GoogleSignin.configure();
    debugger;
    const user = await GoogleSignin.signIn();
    debugger;

But when we hit signin the "GIDSignIn.sharedInstance" referenced has a null configuration property.

If I set it explicity in the config then I get the google sign in popup just fine, without that, I just get No active configuration. Make sure GIDClientID is set in Info.plist

cla-bot[bot] commented 8 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @sitefinitysteve. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

sitefinitysteve commented 8 months ago

@cla-bot check

cla-bot[bot] commented 8 months ago

The cla-bot has been summoned, and re-checked this pull request!

sitefinitysteve commented 7 months ago

@NathanWalker Any chance this could get approved so i don't need to keep manually adding the change on "ns clean"?

NathanWalker commented 7 months ago

Published with 2.1.0

sitefinitysteve commented 7 months ago

Appreciate it a lot man, there's no way I was remembering I had a PR in for this in 6 months. If I had a dime for how many times I've had to refactor firebase auth over the years...