search

NativeScript / plugins

@nativescript plugins to help with your developments.
https://docs.nativescript.org/plugins/index.html
Apache License 2.0
187 stars 104 forks source link

Fix animated miss implemented for android #552

Closed kefahB closed 7 months ago

kefahB commented 7 months ago

Hi @NathanWalker,

The animated property was miss implemented for android, the circle is animated even if we sat animated = false and make the animation restarted for each iteration because of the continuous update of the progress property, then the last one is animated but too lately.

CatchABus commented 7 months ago

@kefahB Let me also point out this line: https://github.com/NativeScript/plugins/blob/main/packages/animated-circle/index.android.ts#L42 You might have to check animated flag there too.

NathanWalker commented 7 months ago

Thanks @CatchABus I'll merge and fix up last condition within initNativeView there, thanks @kefahB for effort here!

NathanWalker commented 7 months ago

Published in 1.2.0