NativeScript / push-plugin

Contains the source code for the Push Plugin.
Apache License 2.0
123 stars 45 forks source link

google-services.json search doesn't respect nsconfig.json #219

Closed hgmich closed 6 years ago

hgmich commented 6 years ago

The nsconfig.json isn't checked for the appropriate resources path, so if a project uses nsconfig.json to define a custom path for the app, it won't work correctly unless the standard app/App_Resources hierarchy is created.

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Set up a new NativeScript project for Android, put an nsconfig.json in the base with the key appResourcesPath set to a non-default location, and then put a valid google-services.json there under the Android subfolder.

Is there any code involved?

Should show on any project with the setup as above.

zbranzov commented 6 years ago

The fix is released in 1.1.4 version of the plugin.