NativeScript / theme

@nativescript/theme
https://v7.docs.nativescript.org/ui/theme
Apache License 2.0
128 stars 44 forks source link

Label font size doesn't match --const-font-size #220

Open mukaschultze opened 5 years ago

mukaschultze commented 5 years ago

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

Describe the bug

Default font size is set to 10, although the --const-font-size is 12.

This seems to be a regression from v2.1.2, as it only happens on v2.2.0. Below is a comparison between v2.1.2 (left) and v2.2.0 (right):

FotoJet

To Reproduce

<Label text="Font size: 8" fontSize="8"></Label>
<Label text="Font size: 9" fontSize="9"></Label>
<Label text="Font size: 10" fontSize="10"></Label>
<Label text="Font size: 11" fontSize="11"></Label>
<Label text="Font size: 12" fontSize="12"></Label>
<Label text="Font size: Default"></Label>
<Label text="Font size: 13" fontSize="13"></Label>
<Label text="Font size: 14" fontSize="14"></Label>
<Label text="Font size: 15" fontSize="15"></Label>

Expected behavior

Label font size should be 12 or --const-font-size variable should be 10. Code where font-size is set to 10

Sample project

Additional context

I'm using Kendo UI default theme

bundyo commented 5 years ago

Thanks for the report!

bundyo commented 5 years ago

Interestingly I couldn't reproduce this here. However I noticed that $font-size is declared twice, so I removed one and adjusted the size classes. Default size should be 12.