search

NativeScript / theme

@nativescript/theme
https://v7.docs.nativescript.org/ui/theme
Apache License 2.0
128 stars 44 forks source link

fix(bootstrap): Remove the second definition of $font-size, fix… #222

Closed bundyo closed 4 years ago

MartoYankov commented 5 years ago

Is this whole construct really necessary? When I use t-XX I expect my font size to be exactly XX regardless of the global $font-size variable.

bundyo commented 5 years ago

I was actually thinking the same. Probably this is a mechanism in Bootstrap to be able to change all sizes in your app by just changing the $font-size. Something like building your site on em/rem units, but without them. :)

We can remove it along with Bootstrap when the time comes.

MartoYankov commented 5 years ago

I don't think removing bootstrap will be anytime soon, so I'm all for hard-coding these in favor of a simpler and more maintainable code for the time being.

MartoYankov commented 5 years ago

Also, please change the PR title to fit the semantic pull request guidelines. These are important for our release notes.