NativeScript / theme

@nativescript/theme
https://v7.docs.nativescript.org/ui/theme
Apache License 2.0
128 stars 45 forks source link

Remove element locks on classes #261

Closed PeterStaev closed 4 years ago

PeterStaev commented 4 years ago

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

Describe the bug Currently many classes are element locked. This means that the classes work ONLY if you use them with the stock/nativescript-ui plugins. This limits the ability for users to use the new classes on custom plugins (either installed through npm or locally created plugins)

To Reproduce A simple example: With 1.0 having the following makes both controls styled exactly the same and makes UI consistent:

<TextField class="input input-border"></TextField>
<m:MaskedTextField class="input input-border></m:MaskedTextField>

With the new 2.0 theme (in non-cmpat mode) having the following styles only the TextField control

<TextField class="nt-input -border"></TextField>
<m:MaskedTextField class="nt-input -border></m:MaskedTextField>

Expected behavior ALL the classes should have the element locks removed so they can be applied to any custom control.

Sample project

Additional context