Sagerahl
commented
1 month ago Update on GitHub Actions (see e08cd55):
- I’ve updated the GitHub Actions workflow to ensure that Playwright tests are run before deployment. If the tests fail, the deployment will be stopped.
- I’ve also added a manual deployment option via the workflow_dispatch event, allowing for manual deployments when needed.
Branch Protection and Development Branch:
-
I’ve created a develop branch for ongoing development. All new features and changes should be pushed to develop and tested before being merged into main. This will help isolate development from production, ensuring that main remains stable. Developers can now create pull requests from develop to main after passing all tests.
-
Since I don’t have the necessary permissions to modify branch protection settings, I would need your help to disable direct pushes to main by enabling branch protection rules, ensuring all changes go through a pull request with proper review and tests.
Problem
https://github.com/Natixar/Blockchain-frontend/blob/cb0d07e4cb5f62c82b7418b30cecd8560df6a5b1/.github/workflows/deploy.yml#L4 There is no way to deploy the current version to a new server.
How to Reproduce?
Go to Actions and there is no option to deploy.
What is Needed Instead?
Automatic deploy on pushes to the main branch should only be used when direct pushes to the main branch are disabled, and only allowed after a thorough review via a pull request. It is not acceptable to let the server-hosted version update when anyone pushes anything, without a prior review and sufficient quality control (like checking that the unit tests actually run).
Manual deploys must be allowed to install the main branch version to a new testing environment too.