search

Natixar / natixar-frontend

The static front end of the Natixar SaaS platform
0 stars 5 forks source link

There are up to 6 top level categories in current taxonomies #21

Closed lepeuvedic-natixar closed 6 months ago

lepeuvedic-natixar commented 7 months ago

https://github.com/Natixar/natixar-frontend/blob/ef02efb304be15fcc3db79dec95d395414c956e3/src/components/natixarComponents/CO2DonutSection/EmissionByScopeDonutSection.tsx#L45

The BEGESv5 taxonomy has 6 top level categories, but only three colors and three text colors are defined here. Please use an online palette generator to generate six suitable colors / text colors.

astowny commented 7 months ago

Fixed in 938847b9178d8dc442484ba39a5187a4fe3c5cb2

lepeuvedic-natixar commented 7 months ago

The change adds more colors to the table, but the fact is that we still do not have the 6 top level categories in BEGESv5. It may be caused by a problem in getScopesOfProtocol.

lepeuvedic-natixar commented 7 months ago

There is a refresh problem: the categories are not refreshed when the categories taxonomy is changed from BEGES to something else. But the refresh can be forced by changing back and forth to the Data page, for example. And even when doing that, there are only four top categories displayed in BEGESv5, when there should be six. In the original branch, there is a display issue with the big colored rectangles, and only 2 are actually displayed.

astowny commented 7 months ago

image

I see only 2 top categoris on the main branch for BEGES V5

lepeuvedic-natixar commented 7 months ago

Le 2024-04-22 19:12, Tony Duong a écrit :

image.png (view on web) [1]

I see only 2 top categoris on the main branch for BEGES V5

-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. You are receiving this because you authored the thread.Message ID: @.***>

Display bug on the main branch too, I imagine, but different. Your branch shows 4 TLC. The data describes 6 Top Level Categories.

Links:

[1] https://github.com/Natixar/natixar-frontend/assets/24301264/44a77e25-affa-45a2-a86e-c22f50d4e548 [2] https://github.com/Natixar/natixar-frontend/issues/21#issuecomment-2070285563 [3] https://github.com/notifications/unsubscribe-auth/BFRCGJX5AI5RIFRCYJXN6ETY6VAG7AVCNFSM6AAAAABGP54XD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQGI4DKNJWGM --=_bd8188d45cfd35698976a3a917733880 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Le 2024-04-22 19:12, Tony Duong a écrit :=


image.png (view on web)

I see only 2 top categoris on the main branch for BEGES V5<= /p>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are= receiving this because you authored the thread.Message ID: <= span><Natixar/natixar-frontend/issues/21/2070285563@= github.com>

Display bug on the main branch too, I imagine, but different. Your branc= h shows 4 TLC. The data describes 6 Top Level Categories.

--=_bd8188d45cfd35698976a3a917733880--