search

Natixar / natixar-frontend

The static front end of the Natixar SaaS platform
0 stars 5 forks source link

Corrected the indexing of indexes by coordinates in CDPs #74

Closed lepeuvedic-natixar closed 1 month ago

lepeuvedic-natixar commented 1 month ago

As per the API Specification-Data Endpoint Rev.D the compressed data points coordinates are positions in the arrays containing the hierarchical indexes. The "id" field is only used in conjunction with the "parent" field, to define the hierarchies themselves.

render[bot] commented 1 month ago

Your Render PR Server URL is https://natixar-pr-74.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cp0nruvsc6pc73d1j1c0.

render[bot] commented 1 month ago

A deploy for your Render PR Server at https://natixar-pr-74.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-cp0nruvsc6pc73d1j1c0.

render[bot] commented 1 month ago

Your Render PR Server at https://natixar-pr-74.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-cp0nruvsc6pc73d1j1c0.

ChrisNatixar commented 1 month ago

The calculateTotalAmount and getTimeDeltaForSlot have been changed, there is a very similar total calculation in emissionsGroupByTime which also uses getTimeDeltaForSlot. This calculation should be checked to make sure it hasn't been altered due to these changes.

lepeuvedic-natixar commented 1 month ago

The calculateTotalAmount and getTimeDeltaForSlot have been changed, there is a very similar total calculation in emissionsGroupByTime which also uses getTimeDeltaForSlot. This calculation should be checked to make sure it hasn't been altered due to these changes.

I am checking

lepeuvedic-natixar commented 1 month ago

I did not change results nor semantics for getTimeDeltaForSlot and getTimeOffsetForSlot. Other uses shouldn't be affected, but the calculations may be faulty elsewhere, like they were in totalAmount before my change. I had always wanted to check in the bar chart data was in fact consistent with the donut.

lepeuvedic-natixar commented 1 month ago

emissionsGroupByTime in emissionTransformers.ts

It would sure need to be modified to show break down by scope instead of era, but I'll do that later in a separate change. I'll keep the era breakdown, unfortunately in some taxonomies, era is undefined for some categories, and when this happens, it necessarily propagates to the group. The group has a defined era only when all the grouped categories have the same era, and that's rather infrequent.

I'll just check the calculations to make sure they're correct, or update them, so that they add up, whatever the break down is.

render[bot] commented 1 month ago

Your Render PR Server at https://natixar-pr-74.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-cp0nruvsc6pc73d1j1c0.