Natizyskunk / vscode-sftp

Super fast sftp/ftp extension for VS Code
Other
374 stars 68 forks source link

Save changes in `ipynb` are not recognized #195

Open kklot opened 1 year ago

kklot commented 1 year ago

Do you read the FAQ?

Describe the bug

Other files (markdown, R, python) synced fine when saving with some changes. The .ipynb in the same directory does not.

To Reproduce

Steps to reproduce the behavior:

  1. Create new python notebook and a python file.
  2. Set up SFTP config
  3. write something in each file and save

Expected behavior

Changes in ipynb is detected.

Desktop (please complete the following information):

VSCode Version: Version: 1.71.2
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:05:37.721Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No
Feliks151450 commented 1 year ago

it is likely that the author should add the api: onDidSaveNotebookDocument to detect the save event of an notebook like .ipynb

kizimenko commented 1 year ago

any changes?

Natizyskunk commented 1 year ago

@Natizyskunk I'm gonna take a look at it, it effectively seem that we need to implement the onDidSaveNotebookDocument api.

Malibu351 commented 11 months ago

I have the same problem. Save ipynb files cannot be uploaded .

sudowoodo200 commented 1 month ago

Same problem. Would love a solution since python is one of the biggest drivers of remote dev servers