Natizyskunk / vscode-sftp

Super fast sftp/ftp extension for VS Code
Other
373 stars 68 forks source link

Notification shown when `sftp.upload.activeFile` action is triggered from keyboard shortcut #450

Open AndisGrossteins opened 7 months ago

AndisGrossteins commented 7 months ago

Every time when I trigger sftp.upload.activeFile action using keyboard shortcut (Ctrl+Shift+U) the file in not uploaded and a notification pops up:

Cannot read properties of null (reading '$mid')

However, the notification doesn't appear when triggering the action using editor context menu or command palette. I don't have any other keyboard bindings that could conflict with this one and the keyboard shortcut troubleshooter doesn't show any issues. Even changing the shortcut doesn't change the behavior.

To Reproduce Steps to reproduce the behavior:

  1. Configure a keyboard shortcut for sftp.upload.activeFile action
  2. Open a file
  3. Keep focus in editor
  4. Hit the configured keyboard shortcut
  5. Message pops up

Expected behavior No notifications

Screenshots image

Desktop (please complete the following information):

Extension Logs from Startup - required I have permanently enabled the debug option. There's nothing of importance in the debug logs because action is not triggered.