search

NatoliChris / diablo-benchmark

The "DIstributed Analytical BLOckchain" Benchmark Framework. (Diablo). Measures blockchains with a focus on real-world applications and workload generation.
Apache License 2.0
11 stars 8 forks source link

fix:solana: use durable nonce and rotate node connections #21

Closed lebdron closed 2 years ago

lebdron commented 2 years ago

Signed-off-by: Andrei Lebedev lebdron@gmail.com

What issue # is this merge request related to?

Closes #20

Overview of merge request

(Provide an overview of the merge request)

Proposed Changes

(What files does this add/remove/change, and how? Brief summary)

Additional information

(Please provide any additional information. For example, future considerations or information useful for reviewers.)

lebdron commented 2 years ago

@gauthier-voron finally...

gauthier-voron commented 2 years ago

I'm testing it, for now with 4+1 c5.xlarge instances in a single region. It looks good.

I see the primary is doing a lot of work before the workload generation. Is it generating accounts at this time?

What is the reason for changes to DefaultTimeout and waitingTicker? Could it affect the results produced (and make previous results invalid)?

lebdron commented 2 years ago

I'm testing it, for now with 4+1 c5.xlarge instances in a single region. It looks good.

I see the primary is doing a lot of work before the workload generation. Is it generating accounts at this time?

What is the reason for changes to DefaultTimeout and waitingTicker? Could it affect the results produced (and make previous results invalid)?

@gauthier-voron Yes, now it creates accounts for the nonces, because they have to be initialized anyway, so it does not help to generate them in the genesis block.

I broke waitingTicker in the initial Solana PR, and here I fixed it, because it should be in seconds. For timeout, I'd say it just does not hurt, but it should work without that change too! I can revert the default value.