Natooz / MidiTok

MIDI / symbolic music tokenizers for Deep Learning models 🎶
https://miditok.readthedocs.io/
MIT License
665 stars 81 forks source link

Structured tokenizer order is different from documentation #169

Closed mister-magpie closed 2 months ago

mister-magpie commented 4 months ago

I am using the Structured tokenizer for a project and I noticed that encoded files follow the order: Timeshift, Pitch, Velocity, Duration

In the docs however it indicates that the timeshift token should be at the end.
Is this on purpose or is it bug? In the first case I think the documentation should be updated accordingly.

Natooz commented 4 months ago

Thank you for the note. For structured, the type of the first token (TimeShift of Pitch) isn't really important. If it starts with a Pitch, this means that a the original music file contains a note at the very beginning (tick 0), whereas if it begins with a TimeShift, this means that the first note is actually played after certain period of time (hence time shift). I hope this cleared things up! 🙌

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity.