NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.63k stars 338 forks source link

Roto shapes complete instantly after the final point is connected instead of on mouse release #653

Open Shrinks99 opened 3 years ago

Shrinks99 commented 3 years ago

Problem

Natron allows users to control the length of bezier handles by clicking to create a point, dragging to set the handle length, and letting go once the handle has reached the desired length. When the last point of the shape is connected however, the shape completes instantly. Natron does not allow the user to modify the handles after connecting the point.

Expected behavior: The handles should continue to be able to be set for the last point until the mouse is released. At this point the shape should complete with the handles set as desired.

Actual behavior: The shape completes instantly after connection.

Examples

Here I've recorded 3 examples of completing bezier shapes in Natron, Illustrator, and Nuke. Nuke and Illustrator have slightly different approaches to this, Nuke will continue to modify both sides of the handle while Illustrator will only modify the side that is not yet created. I personally prefer Nuke's approach here because it allows for a greater control of the shape should the angle change.

https://user-images.githubusercontent.com/5672810/125178259-10aa7680-e1b1-11eb-84f2-8f335277c21c.mp4

https://user-images.githubusercontent.com/5672810/125178304-9fb78e80-e1b1-11eb-8f69-95ffa267b1f8.mp4

https://user-images.githubusercontent.com/5672810/125178309-a2b27f00-e1b1-11eb-8ef8-90a6998d5641.mp4

Versions

devernay commented 3 years ago

+ when adding a new point, the tangent end doesn't follow the mouve (but it works when editing tangents) fixed in 50c808c0a