NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.65k stars 338 forks source link

EXR Reader Bug: With file colourspace != outputcolourspace, all layers are set to the output (color) layer #714

Closed Phoenix-64 closed 2 years ago

Phoenix-64 commented 2 years ago

Do to the Bug issue template being broken I am trying to submmit my issue this way

Natron 2.4.1

Windows 10

RAM: 23.8 GB CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz GPU 0: Intel(R) UHD Graphics 630 GPU 1: NVIDIA GeForce GTX 1660 Ti with Max-Q Design

With the file colorspace set to somthing else as output colorspace, using aces_1.2 ocio config. Viewing a multilayer OpenEXR generated by Blenders file output node with three layers: Image.RGBA, AO.RGBA, Emit.RGBA. Display a Layer different the one selected as output layer

No matter how I change the Layer in the Viewer1 only the layer selected as output layer in the Reader1 is displayed. If file colourspace is == output colourspace this problem vanishes.

  1. Download aces_1.2 https://github.com/colour-science/OpenColorIO-Configs/tree/feature/aces-1.2-config/aces_1.2
  2. Start Natron
  3. In Prefrences -> Color Managment select as OpenColorIO configuration Custom configuration and as Custome OpenColorIO configuration file selected aces_1.2/config.ocio
  4. Run Project natron_problem.zip
  5. Make sure exr is loaded properly in both Read nodes
  6. Make sure in node Read1 File colourspaces and Output colourspaces are set to ACES/ACES - ACEScg and Output layer is set to AO.RGBA
  7. Make sure in node Read1_2 File colourspaces is set to ACES/ACES - ACEScg and output colourspace is set to ACES/ACES ACES2065-1 and Output layer is set to AO.RGBA
  8. Make sure Viewer1 Layer is set to I mage.RGBA image
  9. View Read1 node and observe Image.RGBA being properly displayed, colourful image
  10. View Read1_2 node and observe, even though Viewer1 Layer is till set to Image.RGBA, how AO.RGBA, Grayscale image, is displayed.
  11. Wounder why??
devernay commented 2 years ago

Confirmed! simpler way to reproduce (no need to set a custom OCIO config):

What is expected:

devernay commented 2 years ago

I found the bug and I'm fixing it, but be careful that all color layers will be affected by the colorspace change. in the case of your file, this includes the AO layer, which is RGBA, so be careful about that. One solution is to write a single-channel AO

devernay commented 2 years ago

fixed by https://github.com/NatronGitHub/openfx-io/commit/d48adf0b2d028472f71faff75642c82ad4660033

Phoenix-64 commented 2 years ago

Hello, thank you for fixing it so quickly. Yes I am awear that this changes all layers. Have a nice holliday

Frédéric Devernay @.***> schrieb am Fr., 17. Dez. 2021, 10:25:

fixed by @.*** https://github.com/NatronGitHub/openfx-io/commit/d48adf0b2d028472f71faff75642c82ad4660033

— Reply to this email directly, view it on GitHub https://github.com/NatronGitHub/Natron/issues/714#issuecomment-996564471, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMSHKNFVJ7237XF7ATR5HCTURL6Z5ANCNFSM5JL7B63Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>