NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.56k stars 333 forks source link

strcpy error in PythonUtils.cpp #790

Closed a01163125 closed 2 years ago

a01163125 commented 2 years ago

Natron\Global\PythonUtils.cpp char* pathCpy = strcpy(path.c_str());

Error (active) E0167 argument of type "const char " is incompatible with parameter of type "char " Engine
Error (active) E0165 too few arguments in function call Engine

Hi, everyone. I encountered this issue like above. I googled strcpy function, there are no examples like only take single parameter. Is anyone knows the real solution, of course I know I could prefix with (char*) just do not want change the source code.

devernay commented 2 years ago

Yes, this has been here forever, and this was dead code since Natron has not been compiled with Visual Studio for ages (more than 5 years). If you want to help porting Natron so that it compiles with VS, you are very welcome. You should probably use the RB-2.5 branch with qt5.

a01163125 commented 2 years ago

Many thanks anyway.

  1. I will leave this alone temporarily because this is not a big issue.
  2. Yes, I am using vs2019 with Qt5 and did not directly compiled successfully so I used a very stupid way, disassembled everything and re-assemble them up.
  3. Thanks for help and I will try to contribute when convenient in return.
  4. By the way, do you know where can find _PyInitNatronEngine's definition? Should be in a lib file just not sure which one is. @devernay