NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.65k stars 338 forks source link

Enable OpenGL rendering by default in Engine #801

Closed YakoYakoYokuYoku closed 2 years ago

YakoYakoYokuYoku commented 2 years ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

Currently Natron by default disables GPU rendering if running in background, i.e. NatronRenderer, this results in effects not being able to use it and in cases that OpenGL is required the plugin may throw an exception or crash (see this issue comment for more details). A way to fix this is to enable it by default so environments that load OpenGL in a suitable way for Natron can make use of it, even if Natron isn't windowed. In case there's a much better solution out there then this PR could be superseded by another one.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

By rendering a project that uses the Shadertoy plugin with both Natron and NatronRenderer.

Futher details of this pull request

Attempts to fix #779.

devernay commented 2 years ago

see comment in https://github.com/NatronGitHub/Natron/issues/779#issuecomment-1155582033

YakoYakoYokuYoku commented 2 years ago

Closing per request in #779.