NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.54k stars 332 forks source link

(Feature): Command Palette #836

Closed erayerdin closed 1 year ago

erayerdin commented 1 year ago

Make sure to follow our issue report guidelines

Provide a description of your feature request

Command palette is a feature that is widely adopted by code editors. This is how it is in VSCode. It is usually triggered by CTRL+SHIFT+P.

I think Natron would benefit so much from this, especially considering there are a lot of nodes, users could reach to what they want easily.

Is this a realistically implementable feature?

Can you contribute in creating this feature?

Additional details

No response

rodlie commented 1 year ago

Press the TAB key while the nodegraph has focus. Or do you want something else?

erayerdin commented 1 year ago

Press the TAB key while the nodegraph has focus. Or do you want something else?

Wasn't aware this feature existed. I was trying to find every type of node navigating with my mouse.

Please, feel free to close.

devernay commented 1 year ago

Not closing. We need to make this shortcut more visible. Maybe an item in the right-click menu (and btw I don't think than "Find" deserves that place and that room in the right click menu, especially since the shortcut is so easy to remember)

image
devernay commented 1 year ago

I think all items below "Edit" should be in a submenu called "View". And right below that View menu there should be an item "Insert node" hinting at the shortcut "TAB"

Shrinks99 commented 1 year ago

Lots of these seem like menu bar items... Natron doesn't have a "View" menu but it probably should as you say. It does have a "Display" menu which is where project settings are located? I get the rationale behind this (Project settings are an actual window in Natron) but that should probably be moved to "File" to better match other UI conventions with "Display" becoming "View" and moving many of the right click menu options there?

Agreed about putting "Create Node" with the shortcut displayed in the right click menu. Could also double it up in the menu bar which nobody will ever use but it will serve to direct people to the command field.

Screen Shot 2022-10-14 at 2 48 52 PM
devernay commented 1 year ago

Most of these can't be in the menubar, because these shortcuts are specific to when the nodegraph has focus. A menubar that would change with focus would be very unusual, and probably not following most UI guidelines: this usually happens only when switching between applications

Shrinks99 commented 1 year ago

+1, Menu bars shouldn't change with focus of in-application windows. Some apps (Maya) change the menu bar out depending on what view a user is in, I hate this and it adds complexity.

I don't think "Show expressions links", "auto-hide optional inputs", "Display Cache Memory Consumption" and the like are focus-related despite the fact that they only pertain to a certain window? Those seem more like global view options to me rather than context menu actions as they don't actually perform an action within the node graph, they only change how information is conveyed to users. Items like "center on all nodes" and "Find" are good to keep in the context menu as these actions are accessed far more frequently and are dependent on the user currently operating the window.

Adding a separator in the menu bar "View" section to signify that these items are node-graph specific could be helpful.

devernay commented 1 year ago

Here's the new right-click nodegraph menu:

Does that look ok?

image
devernay commented 1 year ago

fixed in https://github.com/NatronGitHub/Natron/commit/89bfde76ba4c489f9880d6ffd315a1966a49d6d0