search

NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.54k stars 332 forks source link

Engine/CLArgs.cpp: allow dot in writer name #840

Closed rodlie closed 1 year ago

rodlie commented 1 year ago

Allow access to writers in a group, see https://discuss.pixls.us/t/rendering-nested-write-nodes/33225

Tested on Windows 11 (NatronRenderer project.ntp -w Group1.Write1).

devernay commented 1 year ago

@rodlie would you be ready for a 2.4.4 release?

devernay commented 1 year ago

(python 2.7)

rodlie commented 1 year ago

Yes, I have a dedicated machine for building RB-2.4, but I have not updated the SDK in a while (OIIO etc).

devernay commented 1 year ago

I think that's ok, the goal is to fix bugs and bring the few new features. OIIO and ffmpeg updates may be valuable, but not necessary.

rodlie commented 1 year ago

Ok, it will then be built against the same SDK as v2.4.3. The machine is up and running.

rodlie commented 1 year ago

BayMax test fails compared to 2.4.3, will need to figure out why.

@@ -195,7 +195,7 @@
 TestVectorToColor : PASS
 TestWave : PASS
 TestZMask : PASS
-BayMax : PASS
+BayMax : FAIL
 GNUVolador : PASS
 Spaceship : PASS
 TestCMD/WriteOIIO1 : PASS

Ref: BayMax-reference8 Out: BayMax-output8 Diff: BayMax-comp8

rodlie commented 1 year ago

So, it's not a problem with the SDK, as building v2.4.3 results in BayMax PASS.

devernay commented 1 year ago

that was a hard one!

culprid: https://github.com/NatronGitHub/openfx-io/pull/23

since YRotate and XRotate don't have the same defaults, this changed the SeNoise default behavior.

Fix: https://github.com/NatronGitHub/openfx-io/commit/a0fa5d734c7a96776ee56828a4b3fcf895f09976

rodlie commented 1 year ago

Great 👍

Just got to work, but will remote in to the machine and start a new build.

I upgraded OIIO from 2.3.11 to 2.3.21 and FFmpeg from 4.4. to 4.4.3. I will not go beyond OIIO 2.3.x and FFmpeg 4.4.x for RB-2.4 (to keep compatibility and don't introduce new issues).