Fixes to get Qt5 working on Windows.

[acolwell]

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

• [x] I've followed the contributing guidelines to the best of my understanding
• [x] I've read and understood the contributing guidelines
• [x] I've formatted my code according to Natron's code style
• [x] I've searched the pull requests tracker to ensure that this PR is not a duplicate

PR Description

What type of PR is this? (Check one of the boxes below)

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly

What does this pull request do?

This change fixes various Qt5 related build busters on Windows.

• Fixes event API function name and signature change in FileTypeMainWindow_win
• Added cast in TaskBar to deal with differing typedefs for WId.
• Replaced the WId _wid member variable in TaskBar with HWND _hwnd since that reflects what the code actually needs and makes it so we only have to cast from WId to HWND in a single location.
• Added some Qt headers to Gui/Pyside_Gui_Python.h and Gui/PythonPanels.h to make shiboken2 happy. It would segfault, complain about unknown types, or complain about not finding suitable default constructors without these.
• Updated tools/jenkins scripts so they could properly handle Qt4 & Qt5 builds on windows.

Have you tested your changes (if applicable)? If so, how?

Yes. I built Qt4 and Qt5 installers on Windows in a MSYS2 environment with tools/jenkins/launchBuildMain.sh. I was able to unzip the generated zip files and launch Natron. I verified I was able to load a simple project in each of these builds, but I did not do exhaustive testing to verify all features work with Qt5.

[acolwell]

Great! Does that mean you are able to make a Qt5 windows build? Does it have issue #846 ? Yes. I am able to make a Qt5 windows build. It does have the issue mentioned on #846. I can look into a solution for that in a follow up PR if you'd like.

[devernay]

846 was fixed by https://github.com/NatronGitHub/Natron/pull/873

[devernay]

@acolwell @rodlie are you both able to make a Qt5 win build? Can we attach one to https://github.com/NatronGitHub/Natron/releases/tag/v2.6.0-alpha1 for testing? Does someone volunteer to do a Linux build as well? The natron-sdk docker image is fairly up-to-date and have Qt5, but the packaging scriptsprobably need to be reworked for Qt5

[rodlie]

are you both able to make a Qt5 win build?

Currently I only have a server that can produce RB-2.4 and RB-2.5 win builds for Qt4. I can probably setup a new MSYS env and start testing, but I don't know how much free time I have this week.

[acolwell]

are you both able to make a Qt5 win build?

Currently I only have a server that can produce RB-2.4 and RB-2.5 win builds for Qt4. I can probably setup a new MSYS env and start testing, but I don't know how much free time I have this week.

I'm happy to setup a fresh MSYS env to do an official RC build. I was doing fresh installs quite often when I was trying to get my build environment setup. I haven't gotten breakpad working yet in my dev builds so I guess I'll have to figure that out.

I was wondering if you all are interested in some changes that I have which rename some of the MINGW packages with a natron_ prefix so that they are easier to differentiate from the official packages. For me at least, it makes it way easier to keep track of what Natron specific stuff I had to install in my MSYS environment.

[rodlie]

I'm happy to setup a fresh MSYS env to do an official RC build.

That would be great :)

I haven't gotten breakpad working yet in my dev builds so I guess I'll have to figure that out.

For some reason it must be built on Windows 8 or lower, if I build breakpad (included with Natron) on Windows 10(+) all crashes are ignored. Same with building it in docker for Linux, will not work. If I build for Linux in an VM or on actual hardware it works.

I modified Natron to produce local crash reports some time ago ...

• https://github.com/rodlie/Natron/compare/RB-2.5...NatronCrashReporter
• https://github.com/NatronGitHub/breakpad
• https://github.com/rodlie/breakdown
• https://github.com/NatronGitHub/breakpad/issues/2

but never finished it due to this issue.

I was wondering if you all are interested in some changes that I have which rename some of the MINGW packages with a natron_ prefix so that they are easier to differentiate from the official packages

I have no problem with that.