Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
[x] I've formatted my code according to Natron's code style
[x] I've searched the pull requests tracker to ensure that this PR is not a duplicate
PR Description
What type of PR is this? (Check one of the boxes below)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
What does this pull request do?
This change fixes the CrashReporter code that launches the actual Natron binary. It removes a parameter that was not needed on Windows that caused the Natron binary to immediately exit. It also fixes the command-line parameters passed to the child process. The old code was passing in the CrashReporter binary name as the first parameter which was causing the command-line parsing code to fail because it interpreted this as an unknown/unhandled parameter.
Have you tested your changes (if applicable)? If so, how?
Yes. I built a Windows build with tools/jenkins/launchBuildMain with DISABLE_BREAKPAD=0. I was able to successfully launch the Natron UI. I then clicked on the "Test Crash Reporting" button in Edit -> Preferences. This brought up the "Problem Report" dialog and I was able to save a minidump locally by clicking the "Save Report" button. With an updated version of Natron breakpad and the updated MinGW packages for Qt5, I was able to view the crash stack trace with minidump_stackwalk and the symbol files generated by tools/jenkins/launchBuildMain.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This change fixes the CrashReporter code that launches the actual Natron binary. It removes a parameter that was not needed on Windows that caused the Natron binary to immediately exit. It also fixes the command-line parameters passed to the child process. The old code was passing in the CrashReporter binary name as the first parameter which was causing the command-line parsing code to fail because it interpreted this as an unknown/unhandled parameter.
Have you tested your changes (if applicable)? If so, how?
Yes. I built a Windows build with tools/jenkins/launchBuildMain with DISABLE_BREAKPAD=0. I was able to successfully launch the Natron UI. I then clicked on the "Test Crash Reporting" button in Edit -> Preferences. This brought up the "Problem Report" dialog and I was able to save a minidump locally by clicking the "Save Report" button. With an updated version of Natron breakpad and the updated MinGW packages for Qt5, I was able to view the crash stack trace with minidump_stackwalk and the symbol files generated by tools/jenkins/launchBuildMain.