NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.54k stars 332 forks source link

Fix expansion-to-defined compiler warnings #883

Closed acolwell closed 1 year ago

acolwell commented 1 year ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

This change fixes the tons of compiler warnings caused by using "defined" in the COMPILER() and COMPILER_XX() macros. I simply removed the defined expression since it isn't necessary. If the preprocessor macro is not defined, it is given a value of 0 which will return the same result as the (defined(X) && (X)) expressions used in these macros.

https://stackoverflow.com/questions/5085392/what-is-the-value-of-an-undefined-constant-used-in-if

Have you tested your changes (if applicable)? If so, how?

Yes. Built the code on Windows and Linux and didn't notice any change in behavior other than a lot less compiler warning messages. ;)