Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
[x] I've formatted my code according to Natron's code style
[x] I've searched the pull requests tracker to ensure that this PR is not a duplicate
PR Description
What type of PR is this? (Check one of the boxes below)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
What does this pull request do?
Recent changes to build-natron.sh, that fix the Mac build, broke the Windows build. This change fixes the Windows build by using a unix version of the SDK_HOME just like PYTHON_HOME. The issue is that both of these paths have drive letters in them which cause problems with the ':' path delimiter used by shiboken2. Using unix paths avoid the unwanted ':'s from the windows paths.
The genDllVersions.sh change simply removes a DLL that is no longer needed. Updating my MSYS2 installation to the latest packages caused this DLL to no longer exist.
Have you tested your changes (if applicable)? If so, how?
Yes. Built a Windows installer with these changes.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Recent changes to build-natron.sh, that fix the Mac build, broke the Windows build. This change fixes the Windows build by using a unix version of the SDK_HOME just like PYTHON_HOME. The issue is that both of these paths have drive letters in them which cause problems with the ':' path delimiter used by shiboken2. Using unix paths avoid the unwanted ':'s from the windows paths.
The genDllVersions.sh change simply removes a DLL that is no longer needed. Updating my MSYS2 installation to the latest packages caused this DLL to no longer exist.
Have you tested your changes (if applicable)? If so, how?
Yes. Built a Windows installer with these changes.