NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.64k stars 338 forks source link

(Bug): UNC Path Support in File Dialogs #896

Closed joshdicarlo closed 1 year ago

joshdicarlo commented 1 year ago

Make sure to follow our issue report guidelines

Natron version

Natron 2.5

Operating system

Windows 10 Professional

System specs

No response

Did you install Natron using the official installer?

Custom installation path

No response

What were you trying to do?

Read, Write, Load Project, or Save Project from network location with UNC path.

In various file dialogs, type a UNC base path matching one confirmed to load when manually typed on a Read node.

Ex:

What did you expect to happen? What happened instead?

What did I expect to happen:

What happened instead:

Step-by-step reproduction instructions

  1. Create a Read Node OR Create a Write Node OR File>Open Project OR File>Save Project
  2. In the file dialog dialog, type a valid UNC path and press enter

Additional details

Note: I am filing this as a bug, since UNC paths are clearly supported in various nodes, but the file dialog's won't browse to them leading me to believe this is a bug.

It is clear that UNC paths are supported from https://github.com/NatronGitHub/Natron/issues/302, and upon testing a Read/Write Node can be manually provided a UNC path, and will successfully read/write from/to it.

Issue persists with with both forward or backward slashes.

Dialog's include:

In a studio environment, custom drive letter mappings are not an option so UNC path support is important.

f-dy commented 1 year ago

can you please try if the bug is also in 2.6 alpha? https://github.com/NatronGitHub/Natron/releases/tag/v2.6.0-alpha1

Is it the same bug as https://github.com/NatronGitHub/Natron/issues/236 ?

joshdicarlo commented 1 year ago

I can try 2.6 Alpha.

While it's possible they are related - this is not the same bug as #236 - which appears to focus on OpenColorIO and underlying symlink support for UNC paths - which could be entirely related to OCIO and not Natron itself.

This bug is directly related to Natron's native file dialogs, where locations on a file server are inaccessible to browse to using UNC paths.

joshdicarlo commented 1 year ago

I tried installing the Alpha but was unable to launch it. I received 4 system errors after multiple installation attempts. Snag_7d53c2ee Snag_7d53ccb2 Snag_7d53d4a1 Snag_7d53dcc0

f-dy commented 1 year ago

@acolwell for the issue with the 2.6 build

acolwell commented 1 year ago

So I have verified that explicitly providing a full path to a file on a network share works, but providing a directory on a share does not allow you to browse the directory. I'm looking into the cause of this right now.

I am not able to reproduce the missing DLL errors though. The alpha build in Natron-RB-2.6-202305242302-b9a9b81-Windows-x86_64.zip installs and runs fine for me on Windows 10 Pro. Those DLLs mentioned in the error dialogs are in the zip file and should be getting copied to the installed directory.

acolwell commented 1 year ago

The fix for this in #901 just landed. It will be available in the next Natron release.