NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.64k stars 338 forks source link

Fix FFmpeg build buster on Windows. #905

Closed acolwell closed 1 year ago

acolwell commented 1 year ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

MinGW started using a newer version of binutils that breaks the ffmpeg build. This change adds the patch that MinGW uses to address this issue in its own FFmpeg package.

Have you tested your changes (if applicable)? If so, how?

Yes. I built the ffmpeg package locally and also verified that the "build pacman repo" GitHub Action builds again (https://github.com/acolwell/Natron/actions/runs/5779385803). This action should also build when this pull request is submitted.

devernay commented 1 year ago

@rodlie if you don't have bandwidth for these reviews, maybe @acolwell should be named "Windows buildmaster", with the authorization to push changes to the buildsystem without code review (as I do for macOS)?