Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
[x] I've formatted my code according to Natron's code style
[x] I've searched the pull requests tracker to ensure that this PR is not a duplicate
PR Description
What type of PR is this? (Check one of the boxes below)
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
What does this pull request do?
Msys2 has removed its firebird2 package. This change replaces the package reference in our mingw-w64-natron-build-deps-qt5 package.
The pacman repo building workflow logic has been reworked so that it generates versioned .zip files and builds the repo locally if it can't download the current repo version. This allows changes to the repo to generate the new zip file AND allows the installer and CI workflows to pass at the same time. This makes it easier to verify that the changes to the repo actually fix build issues when the pull request workflows run.
Have you tested your changes (if applicable)? If so, how?
Yes. I've verified that both the CI and installer builds work again and that both the "pacman repo was downloaded" and the "pacman repo was unavailable, build it locally" paths work as expected. Also the presumits for this pull request should pass with these changes. Before the repo logic changes in this PR, the presubmits would have failed because the new repo would not be available at presubmit time.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Msys2 has removed its firebird2 package. This change replaces the package reference in our mingw-w64-natron-build-deps-qt5 package.
The pacman repo building workflow logic has been reworked so that it generates versioned .zip files and builds the repo locally if it can't download the current repo version. This allows changes to the repo to generate the new zip file AND allows the installer and CI workflows to pass at the same time. This makes it easier to verify that the changes to the repo actually fix build issues when the pull request workflows run.
Have you tested your changes (if applicable)? If so, how?
Yes. I've verified that both the CI and installer builds work again and that both the "pacman repo was downloaded" and the "pacman repo was unavailable, build it locally" paths work as expected. Also the presumits for this pull request should pass with these changes. Before the repo logic changes in this PR, the presubmits would have failed because the new repo would not be available at presubmit time.