NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.53k stars 330 forks source link

Verify plugins are loadable in Windows installer builds and fix missing dependencies #946

Closed acolwell closed 4 months ago

acolwell commented 4 months ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

Have you tested your changes (if applicable)? If so, how?

Yes. I tested that the new logic properly detects that the plugins were not loadable and causes the build to fail (https://github.com/acolwell/Natron/actions/runs/7935008735). I then added the missing dependencies and verified that the build started passing again (https://github.com/acolwell/Natron/actions/runs/7935721812).

Futher details of this pull request

I'm not exactly sure when libheif took on the new dependencies, but I do know my nightly builds were passing even though the plugins had missing dependencies. This change is intended to make it easier to detect when these new dependencies sneak in and break plugin loading.

acolwell commented 4 months ago

Thank you for the quick review. :)