NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.53k stars 330 forks source link

Fix Windows build failure caused by missing dependency. #969

Closed acolwell closed 1 month ago

acolwell commented 1 month ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency.

The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails.

Have you tested your changes (if applicable)? If so, how?

Yes. The build installer action works again and the plugin load verification step now passes on GMIC plugin again. Before this change the GMIC plugin was causing the plugin load verification step to fail because of the missing dependency.

acolwell commented 1 month ago

LGTM. I don't even understand why nghttp2 and nghttp3 are required. Are they used by WebKit?

I'm not sure what they are used for either. The GMIC plugin depends on libcurl, which appears to depend on nghttp2 and nghttp3. I haven't really dug into why libcurl needs these libraries.