NatronGitHub / Natron

Open-source video compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
http://NatronGitHub.github.io
GNU General Public License v2.0
4.72k stars 343 forks source link

Fix Windows installer build by adding missing Arena.ofx dependency #979

Closed acolwell closed 4 months ago

acolwell commented 4 months ago

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

What does this pull request do?

libheif was recently updated in MSYS2 to depend on libopenjph. This change simply adds this dependency so that the installer will build again and pass its dependency checks.

Have you tested your changes (if applicable)? If so, how?

Yes. I verified the Windows installer builds successfully again.

rodlie commented 4 months ago

btw, should probably remove heif in imagemagick/arena. It serves no purpose (OIIO should handle it), don't know why it was added in the first place.

acolwell commented 4 months ago

btw, should probably remove heif in imagemagick/arena. It serves no purpose (OIIO should handle it), don't know why it was added in the first place.

Looks like you turned it on a few years ago. https://github.com/NatronGitHub/Natron/commit/c3052e988c698dab1a87442553b337ec0a513fa6

I can try turning it back off and see what happens.

rodlie commented 4 months ago

Looks like you turned it on a few years ago

Yes, that was since it was enabled on Linux/Mac at some point and I just matched the depends.

Heif might have been enabled in IM for some script usage, don't know.

I can try turning it back off and see what happens.

Nothing in openfx-arena uses or supports heif so should not break anything.

acolwell commented 4 months ago

Looks like you turned it on a few years ago

Yes, that was since it was enabled on Linux/Mac at some point and I just matched the depends.

Heif might have been enabled in IM for some script usage, don't know.

I figured that was the case. I've made a change to turn it off and have started an installer build to see if anything breaks. Once that is done I'll try running Natron-Tests with that build since that test suite uses ImageMagick for image comparisons.

I can try turning it back off and see what happens.

Nothing in openfx-arena uses or supports heif so should not break anything.

Agreed. I'm always down for reducing unnecessary dependencies where possible. :)