search

NatronGitHub / natron-plugins

Natron Community Plugins
https://discuss.pixls.us/c/software/natron
367 stars 66 forks source link

Refactored Audio_VLC. #16

Closed Windows81 closed 2 years ago

Windows81 commented 2 years ago

I greatly simplified the get_viewer process, at the expense of a bit of usability. To compensate, I crafted an error message that provides possible solutions. I also did other things.

Windows81 commented 2 years ago

@rautamiekka: I would like to follow up with this pull request. I haven't heard anything from any of the other maintainers since we reviewed my commits last month. Thanks in advance for the quick response.

rautamiekka commented 2 years ago

I found from the GitHub workflow config, and then from Natron's Wikipedia page, that Python 2.7.x is use, so that's good to know.

If it was me I'd switch the printf-style (%) string ops for "".format(...), but other than that I can't see anything straight up wrong; then again I know nothing about Natron to say if the interface use is even possible like this.

Windows81 commented 2 years ago

I've also come to that same conclusion. I had thought you were one of the maintainers of this repo; I've definitely misread. Importing my version of VLC_Audio works in much the same way as importing other plugins.

cgvirus commented 2 years ago

Hi sorry for the late reply. Missed the notification probably. Merged. Thanks!