Natsiopoulos / ARDL

ARDL, ECM and Bounds-Test for Cointegration
GNU General Public License v3.0
17 stars 9 forks source link

JOSS Review -- tests to verify functionality needed #10

Closed jessie-dotson closed 2 years ago

jessie-dotson commented 2 years ago

The JOSS review checklist includes the item below.

Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?

I didn't see any tests that would fulfill this criteria. Please add either automated tests or outline manual steps to verify functionality. (If the tests or process exists, please label them appropriately.)

Natsiopoulos commented 2 years ago

There are no automated test yet, although we have started working on that. But there are already excessive tests for every function, (most of them included in the internal function parsers as this is the workhorse behind every other function). These are not in an automated format though, but rather manual tests.

As manual tests are permitted, can this be considered as done?

About the verification of the functionality, this has been verified through the recently published paper on the Journal of Applied Econometrics (we added this reference in the new version of the software paper).