Qgis2 comp

[alexgleith]

Hey folks

I have prepared Australian transformations for our existing datums. There's another transform incoming for the new 2020 datum, but the GSB isn't quite released, so I'll save that for a future PR.

One question for this PR is that I've used our (ICSM's) repo as a source for the GSB files. Are you ok with this, or would you prefer we load the GSB files into the same GSB repo as all the others? I'm happy either way, but felt that this way (getting it from ours) is better, as it saves duplication.

Cheers,

Alex

[gioman]

I have prepared Australian transformations for our existing datums. There's another transform incoming for the new 2020 datum, but the GSB isn't quite released, so I'll save that for a future PR.

thanks!

One question for this PR is that I've used our (ICSM's) repo as a source for the GSB files. Are you ok with this, or would you prefer we load the GSB files into the same GSB repo as all the others? I'm happy either way, but felt that this way (getting it from ours) is better, as it saves duplication.

I guess is ok using yours. Anyway I like the idea to keep a repository with all the grids used in the plugin. So I added them here anyway

https://github.com/NaturalGIS/ntv2_transformations_grids_and_sample_data/tree/master/au

speaking about that: do you have any documentation/link/refrence that can be added there?

cheers!

[alexgleith]

Hey @gioman

I fixed the issues with file names in the header.

Also, regarding the GSB files, could you include the license file: https://github.com/icsm-au/transformation_grids/blob/master/LICENSE.md

I'll talk to the ICSM folks and see if we can get a bit of doco on the files. At least a link to the ICSM website. I'll get back to you.

Cheers,

[gioman]

@alexgleith I published a new version of the plugin with the AU transformations. Thanks!

[alexgleith]

Hi @gioman, excellent news! How long does it take to publish?

I ask because we've inadvertently named our GSB files incorrectly, and need to rename them, which will mean the code for the AU transforms needs changing. If I change the names and do another PR, can you merge and publish rapidly? And if so, what time is best to achieve that?!

Another thing, and I might do it in its own PR, but I feel that the GSB download process should probably be refactored, so that if a file is missing it raises an exception rather than downloads the 404.html to the file instead! That process should be pulled out into a separated utilities.py file, and standardised across all the transforms I reckon.

[gioman]

@alexgleith

Hi @gioman, excellent news! How long does it take to publish?

it is quick, just zip the proper code revision and upload to the QGIS plugin repository.

If I change the names and do another PR, can you merge and publish rapidly? And if so, what time is best to achieve that?!

yes no problem. Please use this branch https://github.com/NaturalGIS/ntv2_transformations/tree/aus_transformations

Another thing, and I might do it in its own PR, but I feel that the GSB download process should probably be refactored, so that if a file is missing it raises an exception rather than downloads the 404.html to the file instead! That process should be pulled out into a separated utilities.py file, and standardised across all the transforms I reckon.

I would appreciate a lot (as also the user of the plugin) if you could add this improvement. Is something that for lack of time I would be able to add in the next future.

On another note: it would be good if you could also make a PR (with the AU transformations) against the master branch that has already been ported to qgis3/python3.

cheers!

[alexgleith]

Hi Giovani

I might do the name change later in the week, and I'll shoot it through. There's probably not many users, so it's not that big a deal. If I do it evening my time it will get to you in the morning!

I'll do the other change soon, too.

Regarding Python3/QGIS3, I'm happy to do it. But I'd prefer to wait until QGIS3 is out, so that I can test easily. I don't have a way to run QGIS3.

Regards,

On Wed, 22 Mar 2017 at 18:41 Giovanni Manghi notifications@github.com wrote:

@alexgleith https://github.com/alexgleith

Hi @gioman https://github.com/gioman, excellent news! How long does it take to publish?

it is quick, just zip the proper code revision and upload to the QGIS plugin repository.

If I change the names and do another PR, can you merge and publish rapidly? And if so, what time is best to achieve that?!

yes no problem. Please use this branch https://github.com/NaturalGIS/ntv2_transformations/tree/aus_transformations

Another thing, and I might do it in its own PR, but I feel that the GSB download process should probably be refactored, so that if a file is missing it raises an exception rather than downloads the 404.html to the file instead! That process should be pulled out into a separated utilities.py file, and standardised across all the transforms I reckon.

I would appreciate a lot (as also the user of the plugin) if you could add this improvement. Is something that for lack of time I would be able to add in the next future.

On another note: it would be good if you could also make a PR (with the AU transformations) against the master branch that has already been ported to qgis3/python3.

cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NaturalGIS/ntv2_transformations/pull/22#issuecomment-288321260, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSUXf1J8f-7EBgQWpEUDfnWUXlSe9VJks5roNCVgaJpZM4MhOvZ .

--

Alex Leith 0419 189 050

[gioman]

Hi Giovani I might do the name change later in the week, and I'll shoot it through. There's probably not many users, so it's not that big a deal. If I do it evening my time it will get to you in the morning! I'll do the other change soon, too. Regarding Python3/QGIS3, I'm happy to do it. But I'd prefer to wait until QGIS3 is out, so that I can test easily. I don't have a way to run QGIS3.

ok.

On what platform you work? if you are on Windows or Linux there is a super easy way to install and use QGIS3.

[alexgleith]

I'm on OSX! There probably is a way, but I usually use KynchChaos' builds. There probably is a brew method.

On Wed, 22 Mar 2017 at 22:46 Giovanni Manghi notifications@github.com wrote:

Hi Giovani I might do the name change later in the week, and I'll shoot it through. There's probably not many users, so it's not that big a deal. If I do it evening my time it will get to you in the morning! I'll do the other change soon, too. Regarding Python3/QGIS3, I'm happy to do it. But I'd prefer to wait until QGIS3 is out, so that I can test easily. I don't have a way to run QGIS3.

ok.

On what platform you work? if you are on Windows or Linux there is a super easy way to install and use QGIS3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NaturalGIS/ntv2_transformations/pull/22#issuecomment-288374709, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSUXTNB460zAeJqfypvb8lQU8L507xZks5roQoMgaJpZM4MhOvZ .

--

Alex Leith 0419 189 050