Include `base/view-filters` in all assets that require it to ensure `ckan.views` is available

NaturalHistoryMuseum / ckanext-nhm

A CKAN extension for the Natural History Museum's Data Portal.

GNU General Public License v3.0

25 stars 4 forks source link

Include `base/view-filters` in all assets that require it to ensure `ckan.views` is available #724

Closed jrdh closed 11 months ago

jrdh commented 11 months ago

This fixes the old gallery view not being interactive. I'm not exactly sure why but I think it caused some of our code to fail to initialise properly and then the click events were just being missed. Not sure why this suddenly stopped working either? Bit weird but heyho. It is likely not all of these assets need base/view-filters, I just added it to every asset which included a JS file which references ckan.views to be safe.

Closes: #723

coveralls commented 11 months ago

coverage: 32.901%. remained the same when pulling db9e0dbc61e9c7e6075b9229b93b8d8bf184940c on josh/fix-old-gallery-view into 4fce113167debe49831aa2c1fe001a4626ce6c63 on dev.