NaturalHistoryMuseum / scratchpads2

Scratchpads 2.0
http://scratchpads.org
GNU General Public License v2.0
199 stars 83 forks source link

ICZN issues #3646

Closed informatics-dev closed 11 years ago

informatics-dev commented 11 years ago

Description:

informatics-dev commented 11 years ago

Comment by Alice Heaton

The image issue has been fixed (Confirmed by Ed).

The other issue is a bit more tricky. I wanted to re-run the comments migration, but some of the Migration modules have been disabled - meaning the associated tables which contain information about what has and hasn't been migrated have been removed. This missing tables do not have information about comments, so it might be ok, but I'm a bit wary to do it that way.

informatics-dev commented 11 years ago

Comment by Alice Heaton

Another issue: the migration code has been modified since that migration was done to handle VIDs. In particular there is some special code in destination/comments.inc that fudges the comment's NID back to the proper NID, as it was set to the VID before. The implication is that what the new code expects in the migration map database table is the VID, not the NID. So re-migrating might not work, as it might not detect with comments have already been imported. Edit: Actually this shouldn't be a problem, as the migrate maps should be using the CID not the NID/VID.

informatics-dev commented 11 years ago

Comment by Alice Heaton

And the comment ids were not preserved during migration, so any custom code to copy the comments across will have to keep track of ids to re-map the hierarchy properly.

informatics-dev commented 11 years ago

Comment by Alice Heaton

I did a local test to use the Migrate module to re-migrate the new comments and that worked fine - so this has now been done on the live site too. Waiting for Ed to confirm it's fine.

informatics-dev commented 11 years ago

Comment by Alice Heaton

Confirmed fine by Ed.