Missing Biography tabs - Githubissues

Archilegt commented 2 years ago

Which tabs should be in a typical Biography/People page? These: View (active tab), Edit EXIF Settings, Forum/E-mail integration, OpenID identities, Publications, Shortcuts, Track, Contact Example: https://myriatrix.myspecies.info/users/pdecker

All those tabs except "View" have disappeared from these two Biographies: https://myriatrix.myspecies.info/users/archilegt https://myriatrix.myspecies.info/users/asombke

Could you please restore the tabs for those two biographies? Feedback on what caused this issue is also welcome.

therobyouknow commented 2 years ago

Thank you for advising @Archilegt and in particular with regard to 'restore' - which says that these were visible in the past.

My initial guess is that the fix I did in 2.10 / 2.10.1 for https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6400 now requires some further logic to allow these tabs to show. But it might not be that.

Can you advise on the last time you had seen them working? Don't worry if you can't, I can still investigate. But if you do know, then I could use that date last seen information to test my initial guess above.

Archilegt commented 2 years ago

Hi, Rob! I really have no idea when the tabs disappeared. Also, I can't think of a connection that will cause only those two biographies to lose their tabs, unless that the "age" of the accounts has something to do. Those are the oldest accounts, 3+ years. On the other hand, the content of the tabs is not gone, just the display is disrupted. For example, if you go to the accounts internally, via the menu People, find "asombke", and click on "edit", that will take you to Andy's account overlay, which will still show a bar on the top, containing all the buttons for the content that should be externally displayed as tabs. Internally, in the account overlay, you can still click on one of the buttons, for example "Publications", and that will take you to Andy's Publications tab, externally visible at: https://myriatrix.myspecies.info/user/3/biblio

DavideDalPos commented 2 years ago

I have the same problem with my scratchpad: https://ichneumoninae.myspecies.info/

My tabs are not displaying either: https://ichneumoninae.myspecies.info/users/davide-dal-pos

Archilegt commented 2 years ago

Hi, @therobyouknow . Could you please take a look at this? I really need those two profiles showing their tabs. I can't really understand why just those two profiles were affected, but it should be possible to make the tabs display again, as they should. I imagine that you could internally look at the settings of the other profiles that are working, and change the archilegt and asombke settings accordingly. Maybe is some problem in the "manage view" settings or the like.

therobyouknow commented 2 years ago

This looks OK for

https://myriatrix.myspecies.info/users/pdecker

@Archilegt is this now OK?

BUT

Not OK for @DavideDalPos

https://ichneumoninae.myspecies.info/users/davide-dal-pos

you only have the View tab.

My hope is that if the first site is OK as above, then it could be just a settings thing to re-use for the second site.

Archilegt commented 2 years ago

Hi, Rob. Peter Decker's bio was the example of a working bio with the correct tabs. What was and is still affected are the bios: https://myriatrix.myspecies.info/users/archilegt https://myriatrix.myspecies.info/users/asombke I have no idea why admin bios are missing tabs while others are not affected.

therobyouknow commented 2 years ago

site database config needs to checking to troubleshoot problem potential code fix. reviewed with ben

therobyouknow commented 2 years ago

ongoing analysis, root cause dev notes

The root cause of the missing tabs is this code change: https://github.com/NaturalHistoryMuseum/scratchpads2/commit/c16a224b449f34ab39bc1ce1497929c8fa1628ce#diff-e16cc2e59ada025bd9593ee88f17d9e38392bb7409de029f5a31d6f28898f5fb to fix issue: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6400

It's regression in the above fix. The above change used in the fix for #6400 is to hide tabs not required for taxonomy terms. However, the problem is that hide will take effect on any page that has the same kind of tabs. This is why the tabs are also missing from the user's page, which is the regression - i.e. fixing one thing broke something else.

I confirmed this is the root cause by commenting out the fix and observing the tabs now display.

when logged out

when logged in as maintainer

The solution is to add a check to see what page we're on, in the sites/all/themes/scratchpads/templates/region--content.tpl.php code, to check that if we're on a user page, we don't apply the hide.

Archilegt commented 2 years ago

I confirm that the screenshots for "logged out" and "logged in" show how the biographies are meant to be visualized.

therobyouknow commented 2 years ago

ongoing analysis, dev notes

implementing solution - if on user page don't hide tabs - move that unset inside the if-check for user page...

therobyouknow commented 2 years ago

working solution, tabs for user now display as required ( https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501#issuecomment-1196930009 - see also comment from site admin confirming as such). Test success:

Regression testing to ensure solution for #6400 still works:

(original test results here: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6400#issuecomment-984472924 )

nontaxonomy/term/37297 - test ok:

/morphology/scape - test ok:

Archilegt commented 2 years ago

Hi, @therobyouknow! I sent you a voice message to your 008.

therobyouknow commented 2 years ago

Thank you for your message @Archilegt I listened all the way through. I would like github tickets created for what you have talked about in the message and will listen again and aim to help you with creating those tickets.

I have made a fix and will now need to schedule the release which will be around mid September. The release will include other fixes.

That fix I have made which I describe in my previous comment ( https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501#issuecomment-1224218194 ) should meet your requirement as you advised here: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501#issuecomment-1197044594 Can you confirm this is still the case please?

I would suggest that once we have established this fix does as required we can then look at further separate work based on tickets we make from your comments in the voice mail.

therobyouknow commented 2 years ago

Potentially fixed by solution for: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501

If it is fixed by that then up to 1 hour check with specific where issue of Edit missing seen.

If it's not by that, more of an open investigation as to why menus. Up to 2 days says Ben.

therobyouknow commented 2 years ago

regression testing

Regression testing of that fix for #6501 shows it needs to be refined because some unwanted tabs are now reshowing for non-biological items. What needs to happen is that Drupal system function tabs (View, Edit, Clone etc) need to show, while Scratchpad domain specific tabs are not shown for non-biological tabs.

@Archilegt can you tell me if you want to see this tabs (as highlighted in red box) to appear again for non-biological terms?

https://myriatrix.myspecies.info/nontaxonomy/term/37297

Originally those tabs were hidden, except for View showing:

https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6400#issuecomment-984472924

My belief is that the terms in the highlighted box should not be shown for non-bioligical terms, as the original release for #6400 provided. But any Drupal generic system tabs like View, Edit, Clone should show.

therobyouknow commented 2 years ago

dev notes, comments on approach to working to ensure correct tabs always show

I'm going to come back to this ticket shortly, later today. But I need to work on something else in the sprint to come back after a break in thinking about it, with a fresh pair of eyes about how to ensure the correct tabs always show for various pages (users, terms, content). I think that's reasonable. I think it is just a case or re-ordering the logic and adding some in sites/all/themes/scratchpads/templates/region--content.tpl.php where the changes have been made so far. I can do this but a break to work on something else to come back with a fresh pair of eyes could be helpful.

We have to get this right. #6400 partially got it, but lack of regression testing of the fix there caused this issue #6501. I'd rather give myself time to get it right first or second time, rather than many more multiple goes at it giving the illusion of progress.

therobyouknow commented 2 years ago

ongoing analysis, term page detection

detect if on term page, then check bio or non-bio

therobyouknow commented 2 years ago

solution complete and dev testing passed, including regression, now ready for release

fix restores tabs:

Regression testing

Ensuring that solution for in issue 6400 still works:

Archilegt commented 2 years ago

Can confirm that the tested display is the expected one.

For Scratchpads evolution, we will need to display the Media and Literature tabs for some glossaries, especially morphological glossaries. For bibliographic references in the biblio module, we will add a Morphology field with comma-separated values and autofill capability, drawing from Morphology glossaries.

To move on with development, I need a report on how many active Scratchpads have morphology glossaries, how many of those display images for at least a few terms, and in which way image display is achieved.

therobyouknow commented 1 year ago

Now released to your sites (in release tag 2.11.1) @Archilegt @DavideDalPos

logged in:

https://myriatrix.myspecies.info/users/archilegt