NaturalHistoryMuseum / scratchpads2

Scratchpads 2.0
http://scratchpads.org
GNU General Public License v2.0
199 stars 83 forks source link

Media gallery not indexing correctly #6551

Open Archilegt opened 2 years ago

Archilegt commented 2 years ago

Describe the bug The media gallery "Myriapodes - Fichier allemand" (https://myriatrix.myspecies.info/gallery?page=1&f%5B0%5D=im_field_smg_galleries%3A1493) is not indexing correctly. There are 78 images correctly added and organized internally, but only 69 images are displayed externally. Images MZS-CAMA_0061 to 69 are missing.

To Reproduce Go to the media gallery address above to see the external view with 69 indexed images. Go to "Edit" to open the editor with the 78 media files.

therobyouknow commented 2 years ago

Thank you @Archilegt I will work on fixing this.

To help with my diagnostics - a question I have is: did this always not work or has is stopped working recently. Either possibility will inform me to fix - and help to prevent in the future.

Archilegt commented 2 years ago

Hi, Rob! I have no idea! I created only one image gallery before and did not use it much. This is the first "real try" at working with an image gallery. Something that made the process difficult was that there was no way to choose all uploaded images at once to add them to the gallery. There were ca. 10 images displayed per "overlay page", but only the images on the first overlay page could be clicked and would stay selected. After saving what was clickable, I had to go overlay page by overlay page, and image by image, because only one image would stay selected at the time. For the image gallery to be really useful for bulk uploads, we need 1) to make everything selectable across overlay pages, or 2) to have a "selection by default", because it would also be time-consuming to click e.g. 100 uploaded images one after another just to get them added to an image gallery.

Archilegt commented 2 years ago

Update: All images are showing up now. One thing to look into (from my illiterate perspective) regarding some images showing and some not, would be "cron runs".

therobyouknow commented 2 years ago

@Archilegt thank you very much for the feedback on UX - user experience regarding upload of images - I've created a new feature request issue for this: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6569

Bugs will take priority first and then I'll look at feature requests for improvements like that issue #6569. We're planning a release in the near future to fix bugs.

Confirming I can see all images as expected too, 78 images in total, across 2 pages:

image

image

Thank you for mentioning cron - yes that could be a factor. cron runs every day at 3am for all the sites. We would want to investigate further to see if cron was related to the missing images but determining where to change how often cron runs. cron can be heavy on server usage, so we'd not want it to affect your experience of using the site.

Related issue for enhancement of site performance: We have an issue to look at seeing how we can enhance server performance with 'smarter housekeeping' which includes what cron itself does: https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6524

When you say the images were missing, did they not appear at all or was were they showing as broken?