NaturalHistoryMuseum / scratchpads2

Scratchpads 2.0
http://scratchpads.org
GNU General Public License v2.0
199 stars 83 forks source link

edit function missing from pages [duplicate of #6501] #6596

Closed scratchpads closed 2 years ago

scratchpads commented 2 years ago

Description:

The edit function is missing on a couple of pages on my website. On the 'Recording Agromyzidae' and 'Newsletter' pages, the edit tab has vanished whilst it is still present on all the others.

Please can this be looked at or let me know how to fix this.

Thanks.

therobyouknow commented 2 years ago

ongoing analysis, confirming can see issue and workaround

Thank you Barry, confirming I can see your issue myself:

Recording Agromyzidae

https://agromyzidae.myspecies.info/node/3

image

and Newsletter

https://agromyzidae.myspecies.info/node/4

image

At the moment, I don't know why these have disappeared. No changes have been made that would cause this.

This will need investigation.

workaround

For the time being, the workaround as perhaps you might know is to tack edit onto the end of the URLs to access editing:

Recording Agromyzidae https://agromyzidae.myspecies.info/node/3/edit

Newsletter https://agromyzidae.myspecies.info/node/4/edit

BarryWarrington commented 2 years ago

Thanks Rob. I didn’t know about just adding edit on the end - that’s useful to know!

The issue is also present on this page;

23495858-6397-4D76-A700-3E61CD78722B

There may be other pages too I guess but I haven’t worked through them all (there’s a lot!).

therobyouknow commented 2 years ago

ongoing analysis, dev notes, feedback to user

Thank you Barry, noted about the other pages too.

I can also see this issue on my own test site, on my Introduction tab.

So it could be a scratchpads-wide issue - that can be useful to know to help me characterise the issue and a solution.

Archilegt commented 2 years ago

Edit and Clone tabs also missing in this reference in Myriatrix: https://myriatrix.myspecies.info/content/invasive-species-cylindrodesmus-hirsutus-pocock-diplopoda-polydesmida-haplodesmidae-spreads It seems that there is a broader issue with broken tab associations across Content Types, paradoxically affecting just individual records. I am thinking of the Archilegt and Asombke profiles/biographies in Myriatrix, which are also affected by disassociated tabs while other biographies aren't.

therobyouknow commented 2 years ago

ongoing analysis dev notes, existing fix expected to fix this issue

Fix for this issue https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501 could also fix this issue.

therobyouknow commented 2 years ago

ongoing analysis, dev notes, existing fix expected to fix this issue

Yes, likely that https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501 fixes this issue, as well as the issue it was already about.

With my fix for https://github.com/NaturalHistoryMuseum/scratchpads2/issues/6501, @Archilegt your page https://myriatrix.myspecies.info/content/invasive-species-cylindrodesmus-hirsutus-pocock-diplopoda-polydesmida-haplodesmidae-spreads looks like this on my local personal dev setup, where I have the fix under test - it shows the tabs are displayed as required:

image

And if I switch off my code fix, i.e. just use the current live scratchpads code on master, the tabs are not shown:

image

I will check Barry's site too and with that I am expecting the same positive successful outcome whereby my fix solves this issue.

therobyouknow commented 2 years ago

dev notes, remaining items to complete ticket

Checking Barry's site as I said I would. Couldn't get hold of a copy of his site's db as access to live production not available due to some storage issues TS advised. Expecting this to be resolved so will try now.

Once confirmed Barry's site OK I will regard this ticket as ready for release, with the code implementation for it. Making sure the original fix for something else that caused it still works; we want to keep the fix before but not have its side effects that caused this ticket.

therobyouknow commented 2 years ago

testing, further successful outcome of proposed fix

Yes, as expected, confirming that fix will work for https://agromyzidae.myspecies.info/ following testing a copy of this site local personal dev setup, as screenshot shows:

image
therobyouknow commented 2 years ago

dev notes, getting database copy imported successfully

Barry's database required this solution now documented and committed to sprint release branch, to enable the import to succeed:

https://github.com/NaturalHistoryMuseum/scratchpads2/wiki/DDEV#problem-2

This potentially could happen with other sites as well.

therobyouknow commented 2 years ago

Closing as duplicate of #6501 on the basis that the fix for #6501 also fixes this issue, as confirmed in testing.

Don't worry, this issue will be fixed. #6501 is now place to track the progress on it.

However, regression testing of that fix for #6501 shows it needs to be refined because some unwanted tabs are now reshowing for non-biological items. What needs to happen is that Drupal system function tabs (View, Edit, Clone etc) need to show, while Scratchpad domain specific tabs are not shown for non-biological tabs.