search

NaturalIntelligence / fast-xml-parser

Validate XML, Parse XML and Build XML rapidly without C/C++ based libraries and no callback.
https://naturalintelligence.github.io/fast-xml-parser/
MIT License
2.53k stars 303 forks source link

Fix for null and undefined attributes when building xml (#585) #598

Closed cecia234 closed 1 year ago

cecia234 commented 1 year ago

Purpose / Goal

After the fix null and undefined attributes in the starting object do not cause odd whitespaces and newlines in the built xml, regardless of whether format is true or false. Issue #585

Perf test on XMLBuilder:

Running Suite: XML Builder benchmark
fxp : 76193.36948123561 requests/second
fxp - preserve order : 238552830.29948822 requests/second
xml2js  : 21083.181183955512 requests/second

Type

Please mention the type of PR

amitguptagwl commented 1 year ago

Thanks for your PR. Let me review it.

coveralls commented 1 year ago

Coverage Status

coverage: 98.221% (-0.02%) from 98.24% when pulling 47b93d94d1ab77e9a88e5a194f73f25b3db571fe on cecia234:fix#585 into a04cd1e184eba3bfc1fe3977bf0a802210967451 on NaturalIntelligence:master.