NaturalIntelligence / fast-xml-parser

Validate XML, Parse XML and Build XML rapidly without C/C++ based libraries and no callback.

https://naturalintelligence.github.io/fast-xml-parser/

MIT License

2.43k stars 297 forks source link

Fix stopNodes to work with removeNSPrefix (#607) #608

Closed candrews closed 10 months ago

candrews commented 10 months ago

Purpose / Goal

The stopNodes option currently doesn't work with the remoteNSPrefix option. This pull request fixes that issue and adds tests to demonstrate the fix.

Type

Please mention the type of PR

[X] Bug Fix
[ ] Refactoring / Technology upgrade
[ ] New Feature

amitguptagwl commented 10 months ago

Thanks for the PR. I'll check it ASAP

coveralls commented 10 months ago

coverage: 98.239% (+0.01%) from 98.226% when pulling 37dfbe291e359f4b2b4abc417c13a11edcc9856f on candrews:stopNodes-removeNSPrefix into 3c9e9fe4346a3c9924d4db45e60a7a29c565caac on NaturalIntelligence:master.

amitguptagwl commented 10 months ago

Thanks for your PR. However, this may take little time to publish as I would like to provide a single publish that includes some open bugs.

candrews commented 10 months ago

I'm really eager to be able to use this bug fix. What open bugs are blocking the next release? Maybe I could help address them to move things along.

amitguptagwl commented 10 months ago

Thanks @candrews . I'll fix #610 this weekend and publish.