NaturalIntelligence / fast-xml-parser

Validate XML, Parse XML and Build XML rapidly without C/C++ based libraries and no callback.

https://naturalintelligence.github.io/fast-xml-parser/

MIT License

2.53k stars 303 forks source link

fix #634: build attributes with oneListGroup and attributesGroupName #653

Closed a-rasin closed 2 months ago

a-rasin commented 5 months ago

Don't ignore attributes when building to xml with oneListGroup and attributesGroupName enabled.

Purpose / Goal

Fixes #634

Type

Please mention the type of PR

[X] Bug Fix
[ ] Refactoring / Technology upgrade
[ ] New Feature

coveralls commented 4 months ago

coverage: 98.266% (+0.006%) from 98.26% when pulling 77f8aa33afa182b32fc915f5ef5693a367ade6a2 on a-rasin:master into 91187361b12988ca9a90b028c9e6006ca066be41 on NaturalIntelligence:master.

amitguptagwl commented 4 months ago

Somehow this build is failing everytime.

coveralls commented 2 months ago

coverage: 98.175% (+0.007%) from 98.168% when pulling 52241a45605d0873890560e68e894d12b1b07423 on a-rasin:updated-oneListGroup-plus-attributes into 931e91013b6ea6bb7425c3b1758dc50a6dfc730c on NaturalIntelligence:master.