search

NaturalIntelligence / fast-xml-parser

Validate XML, Parse XML and Build XML rapidly without C/C++ based libraries and no callback.
https://naturalintelligence.github.io/fast-xml-parser/
MIT License
2.53k stars 303 forks source link

chore: add trend image #658

Closed cwtuan closed 3 months ago

cwtuan commented 3 months ago

Thank you for maintaining the fast-xml-parser package. It has been an invaluable tool in my projects, and I truly appreciate the hard work you and the contributors have dedicated to its development.

As an user of this package, I would like to suggest a small enhancement to the README that I believe could benefit potential users. Specifically, I propose adding a trend image. It will visually show the increasing popularity of the fast-xml-parser package over recent years.

New users often look for signs of a well-maintained and widely-used package. A positive download trend can be a persuasive factor. Also, highlighting the growth of the package can encourage more contributions from the community.

Thank you for considering my suggestion.

Here's a preview:

image

amitguptagwl commented 3 months ago

Thanks for the PR. no doubt it can be helpful but the download trends is already present on npm so it'll be helpful for only Github users. Currently, there are lot of contents on the README. And I don't want to push the contents down more. So I was wondering to reduce the size of the graph and move it to graph section.

cwtuan commented 3 months ago

Thank you for your prompt response and for considering my suggestion.

I've reduced the graph width to 50% and moved it to follow the Performance section as suggested. Please review the updated PR at your convenience, and let me know if there are any further adjustments or improvements needed.

Note that while the download trends present on npm are helpful, they only display data for the past year. Adding a longer-term trend graph to the README will visually capture the increasing popularity of the fast-xml-parser package over several years, which might be more persuasive for potential users and contributors.

Thank you again for your guidance.

Here is preview:

image