search

NaturalIntelligence / imglab

To speedup and simplify image labeling/ annotation process with multiple supported formats.
https://solothought.com/imglab/
MIT License
985 stars 609 forks source link

Create Polygon #19

Closed amitguptagwl closed 6 years ago

amitguptagwl commented 6 years ago

Through imglab, you can only make the rectangular labels. As a part of this issue, we want to let user create polygons.

This issue has dependency on issue #17 Create Toolbar

Features

robonetphy commented 6 years ago

hi, there it seems that I can start my contribution to open source with this project. How can I start?

amitguptagwl commented 6 years ago

imglab is a image labeling tool. Our aim is to improve user experience and reduce manual tasks as much as possible. Prerequisite : Watch video tutorial on README.md to understand how does it work. Then read First_Time_Contributors guide.

You need to have basic knowledge of HTML, CSS and JS.

Implementation: Create s separate demo application to draw polygon. If you get success try to embed the code with this application.

aamarill commented 6 years ago

Hello :)

I am looking to make my first open source contribution. I have good HTML, CSS and JS skills. Can I claim this issue?

Thanks in advance!

robonetphy commented 6 years ago

bro I have already claimed the issues please try another one

aamarill commented 6 years ago

@UmangGPatel my apologies, I didn't see your previous message. Best of luck 😄

robonetphy commented 6 years ago

@amitguptagwl Can I make this in html5 using canvas.

amitguptagwl commented 6 years ago

@UmangGPatel If you attempt to do it using HTML5 canvas then you may have to change the existing functionality to create labels (rectangle) and feature points. Which may increase the complexity. So if you feel you can handle all using the HTML5 canvas it is fine.

amitguptagwl commented 6 years ago

@aamarill Please have a look here

amitguptagwl commented 6 years ago

@UmangGPatel any update on the same. Feel free to ask questions to clear any doubt.

robonetphy commented 6 years ago

I have analysed your code and I understand that you are not using canvas and
SVG to draw a rectangle and points.so I have tried your method of plotting point but I have still no idea about how you are drawing a box so guide me @amitguptagwl

amitguptagwl commented 6 years ago

The Box is nothing but a div with border. I create it on mousedown and keep changing it's height and width on mousemove till mouseup.

If you feel that canvas is a good option. Go for that. We may use some libraries for drawing rectangle, point, and polygon. But please keep in mind that all the features should work, like selection of box, moving it on canvas, mouse and key events etc.

amitguptagwl commented 6 years ago

Final UI

amitguptagwl commented 6 years ago

This feature has been covered in new UI renovation.