NaturalIntelligence / imglab

To speedup and simplify image labeling/ annotation process with multiple supported formats.

https://solothought.com/imglab/

MIT License

988 stars 611 forks source link

riot mount method call change #98

Closed prithvihv closed 6 years ago

prithvihv commented 6 years ago

Purpose / Goal

issue #92 refactored code to call the method with only 1 parameter , also used a simple http server to test changes everything seems fine

Type

Please mention the type of PR

[ ] Bug Fix
[ ] Refactoring / Technology upgrade
[ ] New Feature
[ ] Documentation
[x] Refactor

amitguptagwl commented 6 years ago

Have you tested the application? It looks like you've done the changes in the call but no change in workarea.tag.html

prithvihv commented 6 years ago

alright i think i updated that :+1:

amitguptagwl commented 6 years ago

Thanks. Have you tested the application after your changes?

prithvihv commented 6 years ago

i used the app and all the function seemed to be working as before , im not familiar with how riot works . Any thing specific i need to test ? Thank you

amitguptagwl commented 6 years ago

Just import 2-3 images, draw some shapes. Move to another image draw some shapes. Again come back to previous image and see if you can see all previous shapes you drawn. Please also check browser console (F12) for any error.

prithvihv commented 6 years ago

Hey amit , i did that the shapes were still there and no errors :smiley:

amitguptagwl commented 6 years ago

Grt and thanks for the PR.