search

NaturalNode / apparatus

MIT License
128 stars 24 forks source link

Replace optional NPM dependency webworker-threads with web-worker #17

Open onlyurei opened 3 years ago

onlyurei commented 3 years ago

Looks like webworker-threads is not maintained anymore, and the author recommends to use web-worker instead: https://github.com/audreyt/node-webworker-threads/issues/204 https://github.com/audreyt/node-webworker-threads/issues/206

Hugo-ter-Doest commented 3 years ago

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here: https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js Is that what you mean?

I can replace it with webworker.

onlyurei commented 3 years ago

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here: https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js Is that what you mean?

I can replace it with webworker.

@Hugo-ter-Doest Yes, sorry I opened the issue in the wrong repo - was trying to understand the e2e flow of NB classification class.

Hugo-ter-Doest commented 3 years ago

I will ook into this.