search

NaturalNode / apparatus

MIT License
128 stars 24 forks source link

Get rid of redundant method call #9

Closed mamaral closed 8 years ago

mamaral commented 9 years ago

The classify method calls the getClassifications method, does some error checking on the result, and then calls the getClassifications method again, returning the first result's label. It appears as though the getClassifications method is idempotent, and thus calling it again is redundant, so we should use the results from the original method call.

DrDub commented 8 years ago

Good call. Thanks for contributing to apparatus.

mamaral commented 8 years ago

👍