Set drive state minor issue

Naudit / pystorcli2

Python library provides wrapper around storcli tool to manage and control LSI MegaRAID controllers.

BSD 3-Clause "New" or "Revised" License

2 stars 7 forks source link

Set drive state minor issue #12

Closed ulmitov closed 1 year ago

ulmitov commented 1 year ago

Hi,

When setting drive.state= 'good' it fails (i don't have an output to paste right now) since there is no 'good' state, only 'ugood' or 'unconfigured good' while drive.state = 'offline'\'missing'\'online' works well, it makes a little confusion

Thanks

ralequi commented 1 year ago

hmm, the state setter expects a "valid state" in the raw str that storcli expects or, a DriveState valid enum.

I'm checking and maybe forcing to convert into DriveState may fix your issue

ralequi commented 1 year ago

Is this issue fixed? I checked there were a commit a few weeks ago but don't remember if enough or not

ulmitov commented 1 year ago

Didn't check this one, but the code looks totally correct

ralequi commented 1 year ago

Ok, I'm closing this for now...

Reopen if you find it fails again please.

Thanks!